fix(suppression): handle ignores on multi-line implicit concatenations#3189
fix(suppression): handle ignores on multi-line implicit concatenations#3189rexledesma wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @rexledesma! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
e79b9a4 to
92a89ee
Compare
Summary
We did not respect ignore comments for the entirety of a multi-line implicit concatenation. This only happened in
pyrefly check.This occurred because we had thrown away the AST by the time we collect and check for errors. Instead, just reparse it.
Fixes #3188.
Test Plan
cargo testcargo run --check), with the following file: