Skip to content

fix(suppression): handle ignores on multi-line implicit concatenations#3189

Open
rexledesma wants to merge 1 commit intofacebook:mainfrom
rexledesma:rl/reparse-source-on-multiline-suppress
Open

fix(suppression): handle ignores on multi-line implicit concatenations#3189
rexledesma wants to merge 1 commit intofacebook:mainfrom
rexledesma:rl/reparse-source-on-multiline-suppress

Conversation

@rexledesma
Copy link
Copy Markdown
Contributor

Summary

We did not respect ignore comments for the entirety of a multi-line implicit concatenation. This only happened in pyrefly check.

This occurred because we had thrown away the AST by the time we collect and check for errors. Instead, just reparse it.

Fixes #3188.

Test Plan

  • cargo test
  • Manually (e.g. cargo run --check), with the following file:
# lol.py
d = "lol"

x = (
    # pyrefly: ignore [bad-index]                                                                                 
    f"{d['foo']}\n" 
    f"{d['bar']}"
)

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 21, 2026

Hi @rexledesma!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@rexledesma rexledesma force-pushed the rl/reparse-source-on-multiline-suppress branch from e79b9a4 to 92a89ee Compare April 21, 2026 03:38
@meta-cla meta-cla Bot added the cla signed label Apr 21, 2026
@github-actions github-actions Bot added size/s and removed size/s labels Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in multiline implicit string concatenation not properly suppressed

1 participant