also consider the .py of .pyi from stubs-only packages in pyrefly report #3105#3156
Open
jorenham wants to merge 3 commits intofacebook:mainfrom
Open
also consider the .py of .pyi from stubs-only packages in pyrefly report #3105#3156jorenham wants to merge 3 commits intofacebook:mainfrom
.py of .pyi from stubs-only packages in pyrefly report #3105#3156jorenham wants to merge 3 commits intofacebook:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
connernilsen
requested changes
Apr 17, 2026
Contributor
connernilsen
left a comment
connernilsen
left a comment
There was a problem hiding this comment.
Hey @jorenham, thanks for doing this. A few followups
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Let me know when it's ready for another round of review by re-requesting me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyrefly reportwill now also take the source package sources into account when generating a report for stubs-only packages. Fo for e.g.scipy-stubsit'll now also look forscipyin the site packages and "overlay" the.pyisymbols onto the.pyones. This way, symbols missing the stubs will be reported as missing.Fixes #3105 (which I accidentally closes already)
Test Plan
Tests added