Add empty stubs for Django __init__ files #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirn
force-pushed
the
add-__init__-stubs
branch
from
4b2ca44
to
ba87516
Compare
There was a problem hiding this comment.
@gbleaney has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
While Pyre seems to handle the absence of `__init__.pyi` well, there can be problems with other type checkers that use its Django stubs. Adding these stub files makes the others discoverable, much like adding empty `__init__.py` files to Python packages.
dirn
force-pushed
the
add-__init__-stubs
branch
from
ba87516
to
2dbe9a3
Compare
|
@dirn has updated the pull request. You must reimport the pull request before landing. |
|
@gbleaney I rebased this on top of the latest version of |
dirn
added a commit
to PyGotham/awards-2020
that referenced
this pull request
Nov 6, 2020
This is a work-in-progress attempt at switching over to mypy as part of #85. At the moment everything seems to be working except for the some changes to pyre's stubs that are addressed in facebook/pyre-check#321.
There was a problem hiding this comment.
@gbleaney has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Sorry for losing track of this @dirn! I've re-imported and will try to land today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Pyre seems to handle the absence of
__init__.pyiwell, there canbe problems with other type checkers that use its Django stubs. Adding
these stub files makes the others discoverable, much like adding empty
__init__.pyfiles to Python packages.