Fix line number for type error when unpacking a tuple.

Reviewed By: grievejia Differential Revision: D24775172 fbshipit-source-id: 08111e533729e71487680425cb9fda873c8d9c01
facebook · Nov 6, 2020 · e3ddbf1 · e3ddbf1
1 parent d0ad94c
commit e3ddbf1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/analysis/attributeResolution.ml b/analysis/attributeResolution.ml
@@ -3741,16 +3741,11 @@ class base class_metadata_environment dependency =
              Argument.WithPosition.resolved = Tuple (Bounded (Concrete tuple_parameters));
              kind = SingleStar;
              position;
-             _;
+             expression;
             } ->
                 let unpacked_arguments =
                   List.map tuple_parameters ~f:(fun resolved ->
-                      {
-                        Argument.WithPosition.expression = None;
-                        kind = Positional;
-                        resolved;
-                        position;
-                      })
+                      { Argument.WithPosition.expression; kind = Positional; resolved; position })
                 in
                 List.concat [List.rev unpacked_arguments; sofar]
             | _ -> argument :: sofar

diff --git a/analysis/test/integration/methodTest.ml b/analysis/test/integration/methodTest.ml
@@ -864,6 +864,17 @@ let test_check_method_parameters context =
       "Revealed type [-1]: Revealed type for `test.Foo().s` is \
        `List[typing.StaticMethod[typing.Callable(Foo.s)[[], None]]]`.";
     ];
+  assert_type_errors
+    ~include_line_numbers:true
+    {|
+      xs = (1, 2, 3)
+      def foo(x: int, y: int, z: str) -> None: ...
+      foo(*xs)
+    |}
+    [
+      "4: Incompatible parameter type [6]: Expected `str` for 3rd positional only parameter to \
+       call `foo` but got `int`.";
+    ];
   ()