Skip to content

Conversation

@qmaxquique
Copy link

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@vaibhav-kaushal
Copy link

This one's cool! Would make the whole process fast. I can go do something else while the entire stuff is fetched and installed.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@claudiugh
Copy link

hey @qmaxquique, thanks for your change and sorry for the delay. I just merged it internally and it will get pushed upstream sometime next week.

@port8080 port8080 closed this in a2869a0 Feb 12, 2015
@abhiguru abhiguru mentioned this pull request Jan 4, 2017
Atry added a commit to Atry/proxygen that referenced this pull request Sep 1, 2022
…g::glog (facebook#31)

Summary:
X-link: facebook/fb303#31

Previously Folly provided a polyfill of the `GflagsFlagSaver` symbol, which was removed since facebook/folly@4dadde1. Therefore, the `glog` should solve the `GflagsFlagSaver` symbol from `gflags`.

This diff added `gflags` libraries as a dependency of the CMake project `glog::glog` into `fbcode_builder`'s `FindGlog.cmake`, so that the `fbcode_builder` users will be able to automatically link with `gflags`.

Differential Revision: D39220438

fbshipit-source-id: efcdc5f659bf53519573a750072731ad07919411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants