Various fixes for MacOS Mojave 10.14 #3
Conversation
facebook-github-bot
added
the
CLA Signed
|
I'm not quite sure how to interpret the Travis CI failure -- the raw log shows that it does not invoke the |
|
Thanks @jsquyres well take a look at this by Monday. Don’t worry about the Travis build for now. There’s some issues with the docker script with some dependencies which were working on |
|
Also please join our slack https://join.slack.com/t/mvfst/shared_invite/enQtNjE0ODIwNDU3MDU4LWFkOTc0ZTQ4NzczZmE2MjRlMjQxNWQxNDAyYzAzMDQ5MTQ0ZGI0YTJhZWM0MThhM2FiYzc0Zjg3MTYyNDg2MWI it’s a much quicker way to get responses |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks! I just noted on #4 that if I rebase this branch on top of current HEAD (ad12bcc), everything builds properly on MacOS Mojave. Sweet! I didn't push the rebase here to this PR because it would probably make it a little more difficult to track since you already imported these commits internally. There were no conflicts on the rebase, so the net effect is trivial, anyway. |
|
I see that you guys imported these commits internally -- do you know when they will show up here on the open source / github.com side? (I can rebase, if it would help) Thanks! |
|
Thank you @jsquyres for the patch, and sorry for the delay. We were changing few things in the way we consume some of these dependencies and wanted to clear those changes first. I have some suggestions on the script mostly to make the script simpler. |
|
@udippant No worries on the delay; many thanks for your comments / suggestions. I had a few comments / questions back to you... |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
The help message and README.md referred to a "-i" option for build_helper, but it wasn't there. This commit trivially adds it. Signed-off-by: Jeff Squyres <jeff@squyres.com>
MacOS does not have `nproc`. So try searching for `nproc`, and if it's not found, try looking for `sysctl`. If neither are found, default to 4. Signed-off-by: Jeff Squyres <jeff@squyres.com>
Accurately describe when Folly is successfully installed. Signed-off-by: Jeff Squyres <jeff@squyres.com>
MacOS Homebrew installs OpenSSL into a non-default location in order to not unintentionally override the MacOS OpenSSL. So if we see the Homebrew directory, set it into OPENSSL_ROOT_DIR so that cmake will find it. Signed-off-by: Jeff Squyres <jeff@squyres.com>
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This should fix the Travis CI builds. It adds rust toolchain support inside docker and sets the required THRIFT env variable. Pull Request resolved: facebookexperimental/rust-shed#3 Reviewed By: krallin Differential Revision: D18905608 Pulled By: lukaspiatkowski fbshipit-source-id: 5db1eff6f215a6617d8acaa0c99a62d45225956b
Summary: As per design, we are not supposed to honor duplicate byte event registrations. Duplicate is defined by a registration for the same <stream ID, stream offset, callback*> tuple twice. Currently, there is a bug where-in we can register the same byte event a second time *if* there is another byte event for a higher offset that is registered in-between, for the same stream. Example Sequence that triggers the bug: 1. Registration for Stream ID =10, offset = 50, callback = A. This will be successful. 2. Registration for Stream ID = 10, offset = 55, callback = <doesn't matter>. This will be successful. 3. Registration for Stream ID = 10, offset = 50, callback = A. This is a duplicate of #1. This *should not* be honored, but it was being honored (this was the bug). This commit fixes the bug, #3 will return INVALID_OPERATION. Reviewed By: bschlinker, lnicco Differential Revision: D27946237 fbshipit-source-id: f9751ac90159284f86a285e5e0ebb23b83041d2a
4 participants
I cloned this repo for the first time today and ran into a few problems building on MacOS Mojave 10.14.
Here's a small number of standalone fixes to the
build_helper.shscript.