Skip to content

Conversation

@agnosticdev
Copy link
Contributor

Update README echo server sample commands.
The IPv6 localhost address ::1 was added on the client and the -host argument was removed on the server because this is the default address by default.

Update README echo server sample commands. 
The IPv6 localhost address `::1` was added on the client and the `-host` argument was removed on the server because this is the default address by default.
@agnosticdev
Copy link
Contributor Author

agnosticdev commented May 15, 2019

Relates to issue #11

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 15, 2019
@udippant
Copy link
Contributor

While you are at it, can you propagate the FLAGS_host to EchoServer (like we do for EchoClient) and bind to the passed in address (while keeping the default address to ::1) :)?

@agnosticdev
Copy link
Contributor Author

I will start looking into that. Upon completion that will require an update to the README file again so I will make an update to the client and server commands as well.

@agnosticdev
Copy link
Contributor Author

@udippant This PR has been updated with FLAGS_host propagating to the EchoServer.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@udippant has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@udippant
Copy link
Contributor

Thank you! We will review it internally and merge it back.

@agnosticdev
Copy link
Contributor Author

Is there any action needed from me on this PR at this time?

@udippant
Copy link
Contributor

@agnosticdev I have merged it back. Thank you for contributing.

@agnosticdev
Copy link
Contributor Author

Thank you @udippant !

@facebook-github-bot
Copy link
Contributor

@udippant merged this pull request in fe66d5c.

facebook-github-bot pushed a commit that referenced this pull request Feb 13, 2020
)

Summary:
Take the README.md from
https://github.com/facebookexperimental/mononoke/blob/7ead0e29e41aec0771531a4650b6170bc1ff6566/README.md
and apply it on Eden repo.

Re-add the Cargo.toml file that declares Cargo workspace.

Re-add fbcode_builder/getdeps manifest for Mononoke
Pull Request resolved: facebook/sapling#13

Test Plan:
./build/fbcode_builder/getdeps.py build mononoke
  ./build/fbcode_builder/getdeps.py test mononoke

Reviewed By: ahornby

Differential Revision: D19833059

Pulled By: lukaspiatkowski

fbshipit-source-id: fb37e13306c0b9969a7c4e52b05e1a66a577022f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants