Always cancel drain timeout in QuicTransportBase destructor

Summary: This is basically as a safeguard, to ensure that the drain timeout doesn't try to keep running after the destruction of the transport. Reviewed By: jbeshay Differential Revision: D52267494 fbshipit-source-id: d9ba99e499de7d01281b56bec40298f4e52e6fca
facebook · Dec 19, 2023 · 3ba2147 · 3ba2147
1 parent 4c84710
commit 3ba2147
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/quic/api/QuicTransportBase.cpp b/quic/api/QuicTransportBase.cpp
@@ -167,6 +167,8 @@ const folly::SocketAddress& QuicTransportBase::getLocalAddress() const {
 
 QuicTransportBase::~QuicTransportBase() {
   resetConnectionCallbacks();
+  // Just in case this ended up hanging around.
+  cancelTimeout(&drainTimeout_);
 
   // closeImpl and closeUdpSocket should have been triggered by destructor of
   // derived class to ensure that observers are properly notified