Support fsevents watcher on Apple silicon#875
Closed
robhogan wants to merge 1 commit into
Closed
Conversation
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
a709f7a to
bc765b5
Compare
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If Watchman is unavailable or disabled, we try to fall back to
FSEventsWatcherand then toNodeWatcher.FSEventsWatcheris only available ondarwin, so werequireit in a try/catch and swallow any error.This was hiding the fact that
fseventswas also failing to load on Apple silicon:fsevents@2.3introduces support for Apple silicon. This updates to that version, and also adds Flow types based on the TypeScript types bundled withfseventsso that Flow check passes ondarwin(the Flow error wasuntyped-importso the existingcannot-resolve-modulesuppression doesn't work).Test plan
After: