Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config in babel 7 #162

Closed
wants to merge 2 commits into from
Closed

Conversation

gengjiawen
Copy link

@gengjiawen gengjiawen commented Apr 19, 2018

Summary

With those change, react native can fix all jest test.

Test Suites: 2 skipped, 100 passed, 100 of 102 total
Tests:       4 skipped, 553 passed, 557 total
Snapshots:   37 passed, 37 total
Time:        78.455s
Ran all test suites.
Done in 79.46s.

Test plan

pass react native test-ci task.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2018
@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #162 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.02%     
==========================================
  Files         126      126              
  Lines        4520     4522       +2     
==========================================
+ Hits         3668     3669       +1     
- Misses        852      853       +1
Impacted Files Coverage Δ
packages/metro/src/transformer.js 89.79% <50%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e023342...72a31ca. Read the comment docs.

@gengjiawen gengjiawen changed the title fix missing config in babel 7 fix config in babel 7 Apr 19, 2018
gengjiawen referenced this pull request in facebook/react-native Apr 19, 2018
Summary:
BREAKING CHANGE
This change upgrades the React Native build pipeline from Babel 6 to Babel 7

If you use a `.babelrc` then you'll need to update it to Babel 7 (note that some plugins are no longer relevant, some plugins are automatically upgraded, and some will need some manual love).

Note that you may also need to upgrade your dev env, tests etc, to make sure they work with Babel 7.

Reviewed By: mjesun

Differential Revision: D7591303

fbshipit-source-id: 29cef21f6466633a9c366d1f3c0d3cf874c714db
@gengjiawen
Copy link
Author

gengjiawen commented Apr 20, 2018

@rafeca Can you review this pr ? Thanks.

@gengjiawen
Copy link
Author

@qfox Can you take a look at this pr, set options on preprocessor won't work.

@pvdz
Copy link

pvdz commented Apr 20, 2018

@gengjiawen this problem should be resolved once the lockdown lands. For now your workaround is to manually and explicitly install babel at 7.0.0-beta.40

These api changes were added later (which is why they slipped under our radar). The lockdown fixes will hopefully be published in a new version today.

Note that if you still require the BABEL_VERSION flag to be set at all then you're using an older version of Metro. Regardless, to fix the option problem you'll need to wait a few hours. Working hard on it.

@gengjiawen
Copy link
Author

Okay, but add options like this facebook/react-native@da57ae7 won't work, because inside metro won't accept option like this.

@gengjiawen
Copy link
Author

I hope we can fix the ci thing soon :)

@rafeca
Copy link
Contributor

rafeca commented Jun 1, 2018

@qfox is this PR still relevant with your latest changees?

@gengjiawen gengjiawen closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants