metro-config: Add injectProjectRootAsWatchFolder argument to loadConfig and provide fallback for watchFolders
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Folders to an empty array
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
The integration tests failed, the failure seems unrelated to my changes and they pass when ran locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per facebook/react-native#41967 (comment) I would like to expose a way to disable the code path which overrides the
watchFoldersto be able to detect if the user provided a value for it, or not.Test plan
I added a test to verify the expected behaviour:
https://github.com/kraenhansen/metro/blob/e6de60117ea1e099cb417131d57de52250338ca2/packages/metro-config/src/__tests__/loadConfig-test.js#L169-L182