Deprecate Java YogaConfig.setUseLegacyStretchBehaviour() #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 44e5fc59949a0f989cc1f7f66b882b9371728a81
NickGerleman
force-pushed
the
export-D45300343
branch
from
43519c6
to
c14bc9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 0beb0049c96d0681026d78507e4d9d329e1d1665
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 26, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 782dcbdaa27da5ffd7a7c48253dec6457821ded6
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 26, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 36c24caa4b768bff8aa7e42098a909cd6387f959
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: ed57a4c6ff60af46e097d46f950cecadd8bb8ec8
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 26, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 48bcbcddb9e7d8a54de0728238987549d8ba1f6a
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: f203f8dbfee5d97b201901ad84bab685e868f075
NickGerleman
force-pushed
the
export-D45300343
branch
from
c14bc9b
to
7360cfa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: d7a5db66ce63d0fbd9271d10e0c095bcafeb1f26
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 26, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 17618a9448f661fd14e804fa5d03e2ba196a15d8
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: d7678fb7ea95d1e4f8a3a0d125f1c239dce11f57
NickGerleman
force-pushed
the
export-D45300343
branch
from
7360cfa
to
fb54793
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 83cd2b9cd6930b142b774b5978bac92f8303beb9
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 26, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: 4009476920df349b494fba7411b2564773b41ae3
NickGerleman
force-pushed
the
export-D45300343
branch
from
fb54793
to
df7d675
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 26, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Differential Revision: D45300343 fbshipit-source-id: dd3ee092ea5f6a42d50d03abe50062b633b0611e
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 434eee78cea0490d92caca6574bc67aa1530562c
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: b0edbebd02c1cc569657e7e99904c531d48cc2c1
NickGerleman
force-pushed
the
export-D45300343
branch
from
df7d675
to
aae2725
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: de1f99a4597a5dd4a48f0e7e7aa00fbe6b013898
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: a1b97812d0b1643d3bfdaa7302efa5097a6e5f6f
NickGerleman
force-pushed
the
export-D45300343
branch
from
cc91fb0
to
a7792a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 2aa52a29e00b4a11ee85a8d91e6a4e6be1a92a40
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: b500c89ec31d2050d1677cd4b97aeb6f990c38ed
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: b81c0ef2f73ba7b558c4a697652dc0fc687b956b
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 482a33e3b80d1466f12248de0351efc30fce6932
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 3f2e5224da2249d2b5272b37b6e5b33d200592e7
NickGerleman
force-pushed
the
export-D45300343
branch
from
a7792a2
to
a470bec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 1603e4d2a1f1ffb91b3c61d1fe01fe591af1016e
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: c347bacb5fe14e9115c50917d345f2943981b41a
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
added a commit
to NickGerleman/litho
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 929d835d617580fca75560d416d5c539213572f5
NickGerleman
force-pushed
the
export-D45300343
branch
from
a470bec
to
ca9ac3b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: c6113c75d78deb158c4ca2646656524e8d8b1193
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 5690f6179bbc7791f950305293bc943d26984554
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: f927e0a2e26e8349f94cde56255dd69bc63fc32f
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: facebook#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: eb26561740577459eb6c82ecaede7571dea4a3ed
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 382ac46d8617bee035cc57d6a30dc4b230db0f20
Summary: This searches fbsource for the following strings corresponding to node or config creation using Yoga Java bindings. 1. `YogaNodeFactory.create` 2. `YogaConfigFactory.create` Apart from benchmarks/tests, thie leaves RN Paper, Litho and Native Templates. These are opted into compatibility with current Yoga behavior, using either `YogaErrata.CLASSIC`, or `YogaErrata.ALL` where `UseLegacyStretchBehaviour` is currently set. Differential Revision: https://internalfb.com/D45299721 fbshipit-source-id: 29aeaec903873bc1dc005a6b2c7a014264aa8be9
Summary: X-link: facebook/react-native#37095 X-link: facebook/yoga#1262 Pull Request resolved: facebook#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 65f7aff101b59a0ebc666f279a7a0a92a3a9fcfc
|
This pull request was exported from Phabricator. Differential Revision: D45300343 |
NickGerleman
force-pushed
the
export-D45300343
branch
from
ca9ac3b
to
45a93f6
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37095 Pull Request resolved: #1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 1ecb2b25021f43a0c97ae6e7976317d28551abea
|
This pull request has been merged in 1aa2e16. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: #37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 1ecb2b25021f43a0c97ae6e7976317d28551abea
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 1ecb2b25021f43a0c97ae6e7976317d28551abea
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: Pull Request resolved: facebook#37095 X-link: facebook/yoga#1262 X-link: facebook/litho#942 Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing. Reviewed By: yungsters Differential Revision: D45300343 fbshipit-source-id: 1ecb2b25021f43a0c97ae6e7976317d28551abea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Now that our own usages are removed, mark this as deprecated to encourage users to move to the errata API. The same will be done to variants of this function on other platforms before releasing, and the functions will be removed after releasing.
Differential Revision: D45300343