Remove LooperMode.LEGACY from tests that do not need it #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests have been annotated with @LooperMode(LEGACY), but some of them do not really need it and run successfully without it.
|
Hi team, just wanted to check whether you had any feedback on this PR. Thanks! |
There was a problem hiding this comment.
@colriot has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many tests were previously annotated with @LooperMode(LEGACY) because
they were failing when using the new Robolectric PAUSED LooperMode. I have reran
these tests after Litho upgraded to Robolectric 4.4 and some of them no longer
need @LooperMode(LEGACY) and they run successfully without this annotation,
using the new PAUSED LooperMode.
Changelog
Remove LooperMode.LEGACY from tests that run successfully without it.
Test Plan
N/A, this change only affects tests.