Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose font descent in Litho Text Spec #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose font descent in Litho Text Spec #758

wants to merge 2 commits into from

Conversation

edwardfoux
Copy link

Summary

This will allow us to extract font specs in Elements TextComponentSpec for calculating baseline last height by reflection:

Field field = Text.class.getDeclaredField("measuredLineDescent");
TextPaint paint = (TextPaint) field.get(textComponent);

Changelog

Expose font descent in Litho Text Spec

@facebook-github-bot
Copy link
Contributor

Hi @edwardfoux!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arpitratan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@vinc3m1
Copy link
Contributor

vinc3m1 commented Jul 2, 2021

bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants