Fix litho-core buck files #751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: autoglob is internal-only Differential Revision: D25804146 fbshipit-source-id: 71bf44052225dd84284dc797f27f8423586c5ae9
Summary: This was broken in OSS Differential Revision: D25804645 fbshipit-source-id: 23f6a0c5e841bfefa08af0d8741dc16369d82c73
|
This pull request was exported from Phabricator. Differential Revision: D25804645 |
|
The contributing guide https://github.com/facebook/litho/blob/master/CONTRIBUTING.md shows options for both Buck and Gradle. Is Buck preferred, or both should stay working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was broken in OSS
Differential Revision: D25804645