-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an AdapterProxy to directly call through to underlying Adapter #481
Open
vinc3m1
wants to merge
1
commit into
facebook:master
Choose a base branch
from
vinc3m1:adapterproxy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
litho-widget/src/main/java/com/facebook/litho/widget/AdapterProxy.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.facebook.litho.widget; | ||
|
||
import android.support.v7.widget.RecyclerView; | ||
import android.view.ViewGroup; | ||
|
||
/** | ||
* A proxy class for RecyclerBinder's internal adapter to directly call through to another | ||
* {@link RecyclerView.Adapter} implementation. Useful for low overhead integration with an existing | ||
* {@link RecyclerView} with mixed Litho and Android views. | ||
*/ | ||
public interface AdapterProxy<H extends RecyclerView.ViewHolder> { | ||
|
||
// Placeholder RenderInfo to signal RecyclerBinder to call directly to AdapterProxy. | ||
RenderInfo PROXY_RENDER_INFO = new BaseRenderInfo(new BaseRenderInfo.Builder() {}) { | ||
@Override | ||
public boolean rendersComponent() { | ||
return false; | ||
} | ||
|
||
@Override | ||
public boolean rendersView() { | ||
return true; | ||
} | ||
|
||
@Override | ||
public String getName() { | ||
return "AdapterProxyRenderInfo"; | ||
} | ||
}; | ||
|
||
H onCreateViewHolder(ViewGroup parent, int viewType); | ||
|
||
void onBindViewHolder(H holder, int position); | ||
|
||
int getItemViewType(int position); | ||
|
||
void onViewRecycled(H holder); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems weird! If
AdapterProxy
is going to be used, maybe thenRenderInfo
should have a method that will indicate whether it should be tracked, otherwise it risks being unmaintainable in case moreRenderInfo
children will be added in the future!