Support circular lazy lists

Summary: We are adding the ability to have circular lazy lists. This was already existing in Sections and now we are exposing it to `LazyList`. For now we are not considering grids because there is some crash when we do it. Reviewed By: pentiumao Differential Revision: D57720803 fbshipit-source-id: 7c7c6f605e466ba8d947d356ecf75c7ca5e7be9e
facebook · May 30, 2024 · 9ee6804 · 9ee6804
1 parent 482b194
commit 9ee6804
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/CollectionLayout.kt b/litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/CollectionLayout.kt
@@ -51,6 +51,7 @@ abstract class CollectionLayout(
     val canMeasureRecycler: Boolean = false,
     mainAxisWrapContent: Boolean = false,
     preAllocationHandler: PreAllocationHandler?,
+    isCircular: Boolean
 ) {
   internal abstract fun createRecyclerConfigurationBuilder(): RecyclerConfiguration.Builder
 
@@ -69,7 +70,8 @@ abstract class CollectionLayout(
                                   preAllocationHandler = preAllocationHandler,
                                   incrementalMountEnabled = isIncrementalMountEnabled),
                           rangeRatio = rangeRatio ?: RecyclerBinderConfig.DEFAULT_RANGE_RATIO,
-                          wrapContent = mainAxisWrapContent))
+                          wrapContent = mainAxisWrapContent,
+                          isCircular = isCircular))
                   .useBackgroundChangeSets(useBackgroundChangeSets)
                   .build())
           .build()
@@ -130,6 +132,7 @@ internal object CollectionLayouts {
       crossAxisWrapMode: CrossAxisWrapMode = CrossAxisWrapMode.NoWrap,
       mainAxisWrapContent: Boolean = false,
       preAllocationHandler: PreAllocationHandler?,
+      isCircular: Boolean
   ): CollectionLayout =
       object :
           CollectionLayout(
@@ -142,7 +145,8 @@ internal object CollectionLayouts {
               hasDynamicItemHeight = crossAxisWrapMode.hasDynamicItemHeight,
               canMeasureRecycler = crossAxisWrapMode.canMeasureRecycler,
               mainAxisWrapContent = mainAxisWrapContent,
-              preAllocationHandler = preAllocationHandler) {
+              preAllocationHandler = preAllocationHandler,
+              isCircular = isCircular) {
         override fun createRecyclerConfigurationBuilder(): RecyclerConfiguration.Builder =
             ListRecyclerConfiguration.create()
                 .snapMode(snapMode)
@@ -181,7 +185,8 @@ internal object CollectionLayouts {
               rangeRatio = rangeRatio,
               useBackgroundChangeSets = useBackgroundChangeSets,
               isReconciliationEnabled = isReconciliationEnabled,
-              preAllocationHandler = preAllocationHandler) {
+              preAllocationHandler = preAllocationHandler,
+              isCircular = false) {
         override fun createRecyclerConfigurationBuilder(): RecyclerConfiguration.Builder =
             GridRecyclerConfiguration.create()
                 .snapMode(snapMode)
@@ -224,7 +229,7 @@ internal object CollectionLayouts {
               isReconciliationEnabled = isReconciliationEnabled,
               isIncrementalMountEnabled = isIncrementalMountEnabled,
               preAllocationHandler = preAllocationHandler,
-          ) {
+              isCircular = false) {
         override fun createRecyclerConfigurationBuilder(): RecyclerConfiguration.Builder =
             StaggeredGridRecyclerConfiguration.create().numSpans(spans).gapStrategy(gapStrategy)
       }

diff --git a/litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyList.kt b/litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyList.kt
@@ -75,6 +75,7 @@ inline fun ResourcesScope.LazyList(
     alwaysDetectDuplicates: Boolean = false,
     fadingEdgeLength: Dimen? = null,
     shouldExcludeFromIncrementalMount: Boolean = false,
+    isCircular: Boolean = false,
     init: LazyListScope.() -> Unit
 ): Component {
   val lazyListScope = LazyListScope(context).apply { init() }
@@ -92,7 +93,8 @@ inline fun ResourcesScope.LazyList(
               isReconciliationEnabled = isReconciliationEnabled,
               preAllocationHandler = preAllocationHandler,
               crossAxisWrapMode = crossAxisWrapMode,
-              mainAxisWrapContent = mainAxisWrapContent),
+              mainAxisWrapContent = mainAxisWrapContent,
+              isCircular = isCircular),
       itemAnimator,
       itemDecoration,
       clipToPadding,