Remove "overlayRenderCount" from LazyCollection

Summary:
This API has been broken for a while and brings confusion for our users multiple times, this diff is getting rid of it.

- https://fb.workplace.com/groups/litho.support/permalink/3792199454434728/
- https://fb.workplace.com/groups/litho.support/permalink/3618480355139973/

Reviewed By: pengj

Differential Revision: D58459773

fbshipit-source-id: eb43cc2ddd36b91700f582cc4238e2ee7e3f4581

litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyCollection.kt

@@ -23,7 +23,6 @@ import com.facebook.litho.Handle
 import com.facebook.litho.KComponent
 import com.facebook.litho.LithoStartupLogger
 import com.facebook.litho.Style
-import com.facebook.litho.config.LithoDebugConfigurations
 import com.facebook.litho.eventHandlerWithReturn
 import com.facebook.litho.kotlinStyle
 import com.facebook.litho.sections.ChangesInfo
@@ -87,7 +86,6 @@ class LazyCollection(
     private val lazyCollectionController: LazyCollectionController? = null,
     private val onDataRendered: OnDataRendered? = null,
     private val childEquivalenceIncludesCommonProps: Boolean = true,
-    private val overlayRenderCount: Boolean = false,
     private val alwaysDetectDuplicates: Boolean = false,
     private val fadingEdgeLength: Dimen? = null,
     private val shouldExcludeFromIncrementalMount: Boolean = false,
@@ -240,10 +238,7 @@ class LazyCollection(
                       parentHeightPercent(item.parentHeightPercent)
                     }
                   }
-                  .component(
-                      if (LithoDebugConfigurations.isDebugModeEnabled && overlayRenderCount)
-                          component.overlayRenderCount
-                      else component)
+                  .component(component)
                   .build()
             })
         .onCheckIsSameItemEventHandler(eventHandlerWithReturn(::isSameID))

litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyGrid.kt

@@ -68,7 +68,6 @@ inline fun ResourcesScope.LazyGrid(
     isReconciliationEnabled: Boolean =
         context.lithoConfiguration.componentsConfig.isReconciliationEnabled,
     childEquivalenceIncludesCommonProps: Boolean = true,
-    overlayRenderCount: Boolean = false,
     alwaysDetectDuplicates: Boolean = false,
     fadingEdgeLength: Dimen? = null,
     preAllocationHandler: PreAllocationHandler? =
@@ -118,7 +117,6 @@ inline fun ResourcesScope.LazyGrid(
       lazyCollectionController,
       onDataRendered,
       childEquivalenceIncludesCommonProps,
-      overlayRenderCount,
       alwaysDetectDuplicates,
       fadingEdgeLength,
       shouldExcludeFromIncrementalMount,

litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyList.kt

@@ -71,7 +71,6 @@ inline fun ResourcesScope.LazyList(
     preAllocationHandler: PreAllocationHandler? =
         context.lithoConfiguration.componentsConfig.preAllocationHandler,
     childEquivalenceIncludesCommonProps: Boolean = true,
-    overlayRenderCount: Boolean = false,
     alwaysDetectDuplicates: Boolean = false,
     fadingEdgeLength: Dimen? = null,
     shouldExcludeFromIncrementalMount: Boolean = false,
@@ -123,7 +122,6 @@ inline fun ResourcesScope.LazyList(
       lazyCollectionController,
       onDataRendered,
       childEquivalenceIncludesCommonProps,
-      overlayRenderCount,
       alwaysDetectDuplicates,
       fadingEdgeLength,
       shouldExcludeFromIncrementalMount,

litho-widget-kotlin/src/main/kotlin/com/facebook/litho/widget/collection/LazyStaggeredGrid.kt

@@ -69,7 +69,6 @@ inline fun ResourcesScope.LazyStaggeredGrid(
         context.lithoConfiguration.componentsConfig.isReconciliationEnabled,
     isIncrementalMountEnabled: Boolean = true,
     childEquivalenceIncludesCommonProps: Boolean = true,
-    overlayRenderCount: Boolean = false,
     alwaysDetectDuplicates: Boolean = false,
     fadingEdgeLength: Dimen? = null,
     preAllocationHandler: PreAllocationHandler? =
@@ -119,7 +118,6 @@ inline fun ResourcesScope.LazyStaggeredGrid(
       lazyCollectionController,
       onDataRendered,
       childEquivalenceIncludesCommonProps,
-      overlayRenderCount,
       alwaysDetectDuplicates,
       fadingEdgeLength,
       shouldExcludeFromIncrementalMount,