Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical] Bug Fix: spliting AutoLinkNode #6631

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[lexical] Bug Fix: spliting AutoLinkNode #6631

wants to merge 5 commits into from
+98 −12

Conversation

strdr4605
Copy link
Contributor

@strdr4605 strdr4605 commented Sep 13, 2024 •
edited
Loading

Description

Closes #6628

Test plan

Before

#6628

After

Screen.Recording.2024-09-13.at.12.21.16.mov

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:04am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:04am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.77 KB (0%)
lexical - esm 29.6 KB (0%)
@lexical/rich-text - cjs 38.24 KB (0%)
@lexical/rich-text - esm 31.46 KB (0%)
@lexical/plain-text - cjs 36.82 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.01 KB (0%)
@lexical/react - esm 32.93 KB (0%)

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Sep 13, 2024
@potatowagon
Copy link
Contributor

from the e2e test results, there seems to be a regression for copy paste

@strdr4605
Copy link
Contributor Author

From the e2e test results, there seems to be a regression for copy paste

Hey @potatowagon, thanks for checking this PR. Before moving on try to fix the regression for copy-paste. I would like to know if the fix is good enough. I did the fix mostly to start a discussion around this issue and see that is the best solution.

@strdr4605
Copy link
Contributor Author

strdr4605 commented Sep 25, 2024 •
edited
Loading

While trying to debug the failing tests I see a strange behavior of the editor in the test and reproducing it manually

image

Here my trying to do the same as the test

Screen.Recording.2024-09-25.at.15.35.54.mov

The result is different. What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Line break inside link node appends text to the end of the current paragraph
4 participants
@strdr4605 @potatowagon @etrepum @facebook-github-bot