You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an HTML block element, contained in another element, has text alighment set,
preserve the alignment, and don't replace from parent's Closes#6162
Test plan
Before
An html text like this: <div><p style="text-align: center;">Hello world!</p></div>
would result in paragraph with no text align,
while an html like this: <div style="text-align: right;"><p style="text-align: center;">Hello world!</p></div>
would set the paragraph's text align to right
After
In both cases above, paragraph preserves it's center alignment
When an HTML block element, contained in another element, has text alighment set, preserve the alignment, and don't replace from parent's Closes #6162
Test plan
Before
An html text like this: <div><p style="text-align: center;">Hello world!</p></div> would result in paragraph with no text align, while an html like this: <div style="text-align: right;"><p style="text-align: center;">Hello world!</p></div> would set the paragraph's text align to right
After
In both cases above, paragraph preserves it's center alignment
An html text like this: <p class="editor-paragraph"><span style="white-space: pre-wrap;">4534</span><span style="color: rgb(255, 185, 140); white-space: pre-wrap;">53</span></p> would result in paragraph with no color,how can i fix this bug?
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.extended-testsRun extended e2e tests on a PR
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook-github-bot
added
the
CLA Signed
nzigopis
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
Description
When an HTML block element, contained in another element, has text alighment set,
preserve the alignment, and don't replace from parent's
Closes #6162
Test plan
Before
An html text like this:
<div><p style="text-align: center;">Hello world!</p></div>would result in paragraph with no text align,
while an html like this:
<div style="text-align: right;"><p style="text-align: center;">Hello world!</p></div>would set the paragraph's text align to right
After
In both cases above, paragraph preserves it's center alignment