Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LexicalNode.isBefore(), clean up and optimize getCommonAncestor, isBefore, getNodesBetween #6310

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+134 −95
Open

fix LexicalNode.isBefore(), clean up and optimize getCommonAncestor, isBefore, getNodesBetween #6310

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
49fbe78
fix LexicalNode.isBefor()
Piechota Jun 14, 2024
09aae52
fix is before when there is offset in element
Piechota Jun 15, 2024
ece22ec
Revert "fix is before when there is offset in element"
Piechota Jun 15, 2024
bd351fc
optimization and fix for getCommonAncestor, isBefore, getNodesBetween
Piechota Jun 16, 2024
985c7aa
additional tests
Piechota Jun 16, 2024
5a98131
fix selection
Piechota Jun 16, 2024
e6fb1db
Merge branch 'main' into fix-isBefore
Piechota Jun 20, 2024
f7f7a56
Merge branch 'main' into fix-isBefore
etrepum Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix is before when there is offset in element 
#3181
  • Loading branch information
@Piechota
Piechota committed Jun 15, 2024
commit 09aae521eedc66b4a49118682b49efadc6c39c50
6 changes: 4 additions & 2 deletions packages/lexical/src/LexicalSelection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,18 @@ export class Point {
isBefore(b: PointType): boolean {
let aNode = this.getNode();
let bNode = b.getNode();
const aOffset = this.offset;
const bOffset = b.offset;
let aOffset = this.offset;
let bOffset = b.offset;

if ($isElementNode(aNode)) {
const aNodeDescendant = aNode.getDescendantByIndex<ElementNode>(aOffset);
aNode = aNodeDescendant != null ? aNodeDescendant : aNode;
aOffset = 0;
}
if ($isElementNode(bNode)) {
const bNodeDescendant = bNode.getDescendantByIndex<ElementNode>(bOffset);
bNode = bNodeDescendant != null ? bNodeDescendant : bNode;
bOffset = 0;
}
if (aNode === bNode) {
return aOffset < bOffset;
Expand Down
Loading