[lexical-link] Fix bug when can't remove link formatting from autolink #6306
+701
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
MaxPlav
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
MaxPlav
force-pushed
the
fix/remove-link-formatting-5607
branch
from
168a9b2 to
e575cfc
Compare
StyleT
reviewed
Jun 13, 2024
| @@ -89,6 +89,11 @@ | |||
| text-decoration: underline; | |||
| cursor: pointer; | |||
| } | |||
| .PlaygroundEditorTheme__hiddenLink { | |||
There was a problem hiding this comment.
I think that instead of masking <a> tag as "regular" text - we shall simply render "hidden link" as <span>
packages/lexical-link/src/index.ts
Outdated
| createDOM(config: EditorConfig): HTMLAnchorElement { | ||
| if (this.__isUnlinked) { | ||
| // render a link that behaves like a span | ||
| const element = document.createElement('a'); |
There was a problem hiding this comment.
Simply use span here? Or no wrapper all together?
MaxPlav
force-pushed
the
fix/remove-link-formatting-5607
branch
from
e575cfc to
30935df
Compare
hi, sure I've added an e2e test and unit tests. Also now the unlinked AutoLink node is rendered as "span" element. For that I had to update several types of the |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a user cannot remove link formatting (unlink) from links created by AutoLinkNode. However, it works for links created by LinkNode. The proposal is to add a flag property in AutoLinkNode to indicate if the link was unlinked. If so, render the link as regular text, keeping styles. The hidden auto-link can become a link again via the Toolbar Link button.
Closes #5607
Test plan
Before
Screen.Recording.2024-06-13.at.15.18.13.mov
After
Screen.Recording.2024-06-13.at.15.20.36.mov