Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to native UUID #5622

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Move to native UUID #5622

merged 1 commit into from
Feb 21, 2024

Conversation

ivailop7
Copy link
Collaborator

Since Node 14, 'uuid' is a NodeJS built-in from the 'crypto' package. Removing it as a direct dependency.

More here:
https://dev.to/pierre/you-should-ditch-uuid-node-has-you-covered-10i3

Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2024 4:07pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2024 4:07pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2024
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in principle - let's figure out the tests.

@ivailop7 ivailop7 merged commit 21d5447 into facebook:main Feb 21, 2024
38 of 45 checks passed
@ivailop7 ivailop7 deleted the native_uuid branch February 21, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants