Revert Fix $transferStartingElementPointToTextPoint() #4756 #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
thegreatercurve
requested review from
zurfyx,
fantactuka and
acywatson
as code owners
zurfyx
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing issues in the
PlainTextPluginprevent users from deleting line breaks within paragraph nodes. When the cursor is collapsed and on aLineBreakNodethe selection is of typeelementwhich causes the condition to trigger, incrementing the offset even during a deletion.I think we can the original PR as it seems more like a browser bug if the base Selection offset isn't being increment for an empty node (e.g. a decorator node).
Before:
Screen.Recording.2023-10-06.at.16.12.33.mov
After:
Screen.Recording.2023-10-06.at.16.11.01.mov