chore: add typedefs for collab nodes and remove unused members #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zignis
requested review from
zurfyx,
fantactuka,
acywatson and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
LGTM, but the unobservers thing looks like a thing that could've been useful for some product use cases, @fantactuka do you have more context on that?
Should be good, never seen it used |
fantactuka
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment typedefs for yjs (collab nodes), and removed unused
_unobserversmember from the collab decorator node