Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextNode override in 'Serialization & Deserialization' doc #5006

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

giacomoran
Copy link
Contributor

Fixes #4987

  • Node overrides don't work if the key of the original node is passed to the replacement node
  • Overriding isSimpleText is needed to replace the default TextNode with ExtendedTextNode without unexpectedly altering Lexical's behavior

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:42pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:42pm

@acywatson acywatson merged commit 64f9d86 into facebook:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Limitations of TextNode node overrides, caused by node.type === 'text' checks
4 participants