Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste merged celled table #4116

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Paste merged celled table #4116

merged 2 commits into from
Mar 15, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 13, 2023

Just adding copy-paste support

Screen.Recording.2023-03-13.at.5.36.58.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2023
@vercel
Copy link

vercel bot commented Mar 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 9:40PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 15, 2023 at 9:40PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 141 ms (+105.01% 🔺) 678 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.69 KB (0%) 754 ms (0%) 65 ms (+30.09% 🔺) 819 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 37.66 KB (0%) 754 ms (0%) 99 ms (+29.35% 🔺) 852 ms

thegreatercurve
thegreatercurve reviewed Mar 14, 2023
View reviewed changes
packages/lexical-table/src/LexicalTableCellNode.ts Outdated
@@ -243,6 +245,10 @@ export function convertTableCellNodeElement(
? TableCellHeaderStates.ROW
: TableCellHeaderStates.NO_STATUS,
);
if (domNode instanceof HTMLTableCellElement) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might need to add CAN_USE_DOM here to guard against any server side rendering bugs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of importDOM, it should be safe from SSR no?

Copy link
Contributor

@acywatson acywatson Mar 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headless tho: #3913

@zurfyx zurfyx merged commit 9333011 into main Mar 15, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the paste-table branch July 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zurfyx @thegreatercurve @acywatson @facebook-github-bot