Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with ArrowDown/ArrowUp in RichTextPlugin #3676

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix bug with ArrowDown/ArrowUp in RichTextPlugin #3676

merged 1 commit into from
Jan 5, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Jan 5, 2023

We should have been checking the decorator is inline or not.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2023
@vercel
Copy link

vercel bot commented Jan 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 5, 2023 at 3:57PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 5, 2023 at 3:57PM (UTC)

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.25 KB (0%) 505 ms (0%) 386 ms (+63.1% 🔺) 891 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.07 KB (0%) 782 ms (0%) 198 ms (-60.92% 🔽) 980 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.04 KB (0%) 781 ms (0%) 387 ms (-37.05% 🔽) 1.2 s

a-xin
a-xin approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@a-xin a-xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trueadm trueadm merged commit a18e04c into main Jan 5, 2023
@trueadm trueadm deleted the revise-key-downup-logic branch January 5, 2023 16:49
@trueadm trueadm mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-xin a-xin a-xin approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @a-xin @facebook-github-bot