Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide commenting controls on mobile screen sizes #3667

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Hide commenting controls on mobile screen sizes #3667

merged 2 commits into from
Jan 3, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Jan 3, 2023

This isn't really a solution, however the commenting UI isn't really approachable on mobile and needs a big rework before we should show it again.

@vercel
Copy link

vercel bot commented Jan 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 11:42AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 11:42AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.24 KB (0%) 505 ms (0%) 296 ms (+19.6% 🔺) 801 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.07 KB (0%) 782 ms (0%) 366 ms (-30.8% 🔽) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.04 KB (0%) 781 ms (0%) 482 ms (-22.73% 🔽) 1.3 s

@trueadm trueadm merged commit a2bdf08 into main Jan 3, 2023
@trueadm trueadm deleted the hide-commenting-mobile branch January 3, 2023 13:40
@trueadm trueadm mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueadm @thegreatercurve @facebook-github-bot