$splitNode & $insertNodeToNearestRoot for root selection #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantactuka
requested review from
trueadm,
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fantactuka
force-pushed
the
split-node-for-root
branch
2 times, most recently
from
cdaa080 to
2f0326d
Compare
fantactuka
force-pushed
the
split-node-for-root
branch
from
2f0326d to
0445905
Compare
fantactuka
force-pushed
the
split-node-for-root
branch
from
0445905 to
60674c0
Compare
trueadm
approved these changes
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$splitNodeto thrown if called on rootIt's possible to keep
$splitNodeworking with root. E.g., if we have root with 2 children, and trying to call$splitNode(root, 1), it'll return[firstRootChild, secondRootChild]without modifying (splitting) the tree. But then it means those children might be elements or decorators, so it would require API call site to check return type. Plus, there's no guarantee that there will be left or/and right tree at all since root can be empty. Supporting all of these will make$splitNodereturn type too vague ([null | ElementNode | DecoratorNode, null | ElementNode | DecoratorNode]) and it seems easier to handle root separately instead$insertNodeToNearestRoot