Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collapsible container plugin example #3369

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Add collapsible container plugin example #3369

merged 1 commit into from
Nov 18, 2022

Conversation

akmarzhan1
Copy link
Contributor

  • created a CodeSandbox example for the collapsible container plugin here
  • added a new page and the example on the website (under “/docs/demos/plugins/collapsible-container”)

Collapsible Container Plugin

Issue #2886

@vercel
Copy link

vercel bot commented Nov 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 11:18PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 11:18PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2022
@thegreatercurve
Copy link
Contributor

@akmarzhan1 I'm not sure if we necessarily need the header with the text "Collapsible Container Plugin Example. Note: this build shows how to use collapsible containers", and the grey background around the text editor. Is that visible within the iframe embed in the docs?

LGTM otherwise!

@thegreatercurve thegreatercurve merged commit 6ee5681 into facebook:main Nov 18, 2022
@akmarzhan1
Copy link
Contributor Author

@akmarzhan1 I'm not sure if we necessarily need the header with the text "Collapsible Container Plugin Example. Note: this build shows how to use collapsible containers", and the grey background around the text editor. Is that visible within the iframe embed in the docs?

LGTM otherwise!

Yep, it is visible, would you prefer if I removed these headers from all of the examples?

@akmarzhan1 akmarzhan1 deleted the inline branch November 22, 2022 00:41
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@akmarzhan1 @thegreatercurve
add collapsible container plugin example (#3369)
4706897
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akmarzhan1 @thegreatercurve @facebook-github-bot