Preserve selection for pending state #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantactuka
requested review from
trueadm,
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Oct 31, 2022
trueadm
reviewed
Oct 31, 2022
| @@ -809,6 +809,8 @@ function beginUpdate( | |||
| try { | |||
| if (editorStateWasCloned && !editor._headless) { | |||
| pendingEditorState._selection = internalCreateSelection(editor); | |||
| } else if (editor._headless && currentEditorState._selection != null) { | |||
| pendingEditorState._selection = currentEditorState._selection.clone(); | |||
There was a problem hiding this comment.
If the editor state wasn't cloned then should you be mutating it?
There was a problem hiding this comment.
Oh, you're right, will fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-headless mode there's a separate logic that either reuses previous selection or relies on dom. For headless we just copy previous selection