Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: draggable block icon is invisible in read-only mode #3198

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: draggable block icon is invisible in read-only mode #3198

merged 1 commit into from
Oct 18, 2022

Conversation

karam-qaoud
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2022
@vercel
Copy link

vercel bot commented Oct 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 5:51PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 5:51PM (UTC)

zurfyx
zurfyx approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Karam! Glad to see you around 😃

@thegreatercurve
Copy link
Contributor

Thanks @karam-qaoud! Hope everything is well.

@karam-qaoud
Copy link
Contributor Author

@zurfyx @thegreatercurve Thanks! I hope you guys are doing well ❤️

@karam-qaoud
Copy link
Contributor Author

Please feel free to merge since I don't have write access 😅

@zurfyx zurfyx merged commit e87d52f into facebook:main Oct 18, 2022
acywatson pushed a commit that referenced this pull request Oct 18, 2022
@karam-qaoud @acywatson
fix: draggable block icon is invisible in read-only mode (#3198)
9149184
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@karam-qaoud @thegreatercurve
fix: draggable block icon is invisible in read-only mode (#3198)
50304f0
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karam-qaoud @thegreatercurve @zurfyx @facebook-github-bot