Add className prop to typeahead plugin #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
trueadm,
zurfyx,
fantactuka,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
approved these changes
Oct 6, 2022
tylerjbainbridge
approved these changes
Oct 6, 2022
| @@ -583,10 +583,10 @@ export function useBasicTypeaheadTriggerMatch( | |||
| function useMenuAnchorRef( | |||
| resolution: Resolution | null, | |||
| setResolution: (r: Resolution | null) => void, | |||
| className?: string, | |||
There was a problem hiding this comment.
Can you change it to anchorClassName? Just want to make to make sure that people don't think this is how you style the typeahead menu itself.
acywatson
added a commit
that referenced
this pull request
Oct 18, 2022
* add className prop to typeahead plugin * fix * rename
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* add className prop to typeahead plugin * fix * rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to add styles to the underlying typeahead menu container. The menuRenderFn doesn't control this part, so it's useful to have a styling hook for it.