Tweet fallback to text on copy #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
trueadm,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
@zurfyx Maybe want to do the same for YouTube nodes as well? |
thegreatercurve
approved these changes
Sep 29, 2022
acywatson
reviewed
Sep 29, 2022
| @@ -175,6 +175,8 @@ export class TweetNode extends DecoratorBlockNode { | |||
| exportDOM(): DOMExportOutput { | |||
| const element = document.createElement('div'); | |||
| element.setAttribute('data-lexical-tweet-id', this.__id); | |||
| const text = document.createTextNode(this.getTextContent()); | |||
| element.append(text); | |||
There was a problem hiding this comment.
I would even say a link for this type of thing - differs by decorator, I suppose.
|
@zurfyx Sorry, I merged this ahead of a sync in error. I think the suggestions can be applied in a separate PR though. |
acywatson
pushed a commit
that referenced
this pull request
Oct 18, 2022
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very opinionated PR but I think having a fallback to text for non-Lexical editors is a much better experience
Screen.Recording.2022-09-29.at.4.53.50.pm.mov