Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editable property being forced to true #2945

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Fix editable property being forced to true #2945

merged 1 commit into from
Sep 5, 2022

Conversation

TimFL
Copy link
Contributor

@TimFL TimFL commented Sep 5, 2022

Fixes #2944

@facebook-github-bot
Copy link
Contributor

Hi @TimFL!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vercel
Copy link

vercel bot commented Sep 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 7:32AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 7:32AM (UTC)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@thegreatercurve
Copy link
Contributor

Thanks for spotting and putting together the fix @TimFL.

@trueadm trueadm merged commit c943aa4 into facebook:main Sep 5, 2022
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@TimFL @thegreatercurve
Fix editable property being forced to true (#2945)
8f0c4f0 
Co-authored-by: Tim Laubert <tim.laubert@azurspace.com>
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Editable: false can't be set via initialConfig (LexicalComposer)
4 participants
@TimFL @facebook-github-bot @thegreatercurve @trueadm