Handle insertTranspose for beforeinput event
#2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantactuka
requested review from
trueadm,
zurfyx,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
approved these changes
Aug 4, 2022
|
Tested with other Emacs key bindings (i.e. CTRL+A to go to the start of a line) to verify fix works. |
fantactuka
force-pushed
the
fix-transpose-event
branch
from
6cf3294 to
8863828
Compare
fantactuka
force-pushed
the
fix-transpose-event
branch
from
8863828 to
07b006d
Compare
fantactuka
force-pushed
the
fix-transpose-event
branch
from
07b006d to
7053a02
Compare
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing
^ + Tworks in Safari since it triggers onbeforeinput withinputType=insertText, while chrome usesinputType=insertTranspose:fix #2751
Screen.Recording.2022-08-04.at.2.58.50.PM.mov