Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexical-playground): code lang display #2658

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix(lexical-playground): code lang display #2658

merged 1 commit into from
Jul 20, 2022

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Jul 19, 2022 •
edited
Loading

Description

Keeps the language name consistent and friendly name.

2022-07-19.22.40.21.mov

closes: #2657

@vercel
Copy link

vercel bot commented Jul 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:21PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 4:21PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2022
@LuciNyan LuciNyan force-pushed the fix-code-lang-display branch from 8c61b35 to 5d8bbde Compare July 19, 2022 14:39
@LuciNyan LuciNyan marked this pull request as ready for review July 19, 2022 14:40
@LuciNyan LuciNyan force-pushed the fix-code-lang-display branch from b768c58 to bf469d7 Compare July 19, 2022 15:32
@LuciNyan LuciNyan force-pushed the fix-code-lang-display branch from bf469d7 to 825abd9 Compare July 19, 2022 16:06
@LuciNyan LuciNyan force-pushed the fix-code-lang-display branch from 825abd9 to 79221d0 Compare July 19, 2022 16:19
thegreatercurve
thegreatercurve reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@thegreatercurve thegreatercurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LuciNyan

@thegreatercurve thegreatercurve merged commit 97734dc into facebook:main Jul 20, 2022
@LuciNyan LuciNyan deleted the fix-code-lang-display branch August 5, 2022 00:57
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@LuciNyan @thegreatercurve
fix(lexical-playground): code lang display (#2658)
4d0ee37
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreatercurve thegreatercurve thegreatercurve approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect language name display in code block
3 participants
@LuciNyan @thegreatercurve @facebook-github-bot