Add ability to set format and details on TextNode by string
#2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegreatercurve
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
tylerjbainbridge
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
approved these changes
Jun 28, 2022
fantactuka
reviewed
Jun 29, 2022
| @@ -500,17 +503,21 @@ export class TextNode extends LexicalNode { | |||
| return; | |||
| } | |||
|
|
|||
| setFormat(format: number): this { | |||
| // TODO 0.4 This should just be a `string`. | |||
There was a problem hiding this comment.
Does it mean we won't be able to set multiple formats, eg bold and italic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to the API of
TextNode, to make the logic consistent withtoggleFormatCloses #2491