Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initializeEditorState on LexicalComposer #2425

Merged
merged 5 commits into from
Jun 16, 2022
Merged

initializeEditorState on LexicalComposer #2425

merged 5 commits into from
Jun 16, 2022

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jun 15, 2022

Seemingly a gimmick but it's actually important for 2 reasons:

  1. Support users to switch between plain text and rich text without conditionals
  2. Fix nested editor initialEditorState population, which is very complicated is things are loosely coupled by plugins. Instead, with a LexicalComposer + NestedLexicalComposer we can handle this easily out of the box

@vercel
Copy link

vercel bot commented Jun 15, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 10:54AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 10:54AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2022
@zurfyx zurfyx merged commit 5be29e5 into main Jun 16, 2022
@barbalex barbalex mentioned this pull request Jun 17, 2022
Closed
@trueadm trueadm deleted the initialize branch December 18, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @trueadm @facebook-github-bot