-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate last 2 packages to TS (10/n) #2237
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
88c9cdf
to
7257372
Compare
6e3f2d6
to
4c004b7
Compare
As all code has been migrated to ts, shouldn't we remove *.d.ts file? |
@yuzhouu We should, but I need to make sure that the auto-generated complimentary Flow Types work with our internal codebase. |
ddb657e
to
2dcd3c5
Compare
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 😍
2dcd3c5
to
38cb1ca
Compare
c0fcd9f
to
623b1f2
Compare
623b1f2
to
41dc36d
Compare
41dc36d
to
7fba7f5
Compare
Closes #1242! This PR includes:
lexical
lexical-yjs
shared-ts
folder to justshared
.I've had to add some
any
types in the Lexical YJS packages as the types are slightly unclear.Migration steps
I ran the below script to update the directories automatically, and then fixed each compiler linter error manually:
Bundle sizes
Bundle sizes are consistent with
main
. Below are some sample packages:Lexical.prod.js
LexicalYJS.prod.js