-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate lexical-react
to TypeScript (7/n)
#2211
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@acywatson I'll rebase the serialization PR on top of this and fix any merge conflict. I just want to try and get the TS stuff before the end of the week. |
That's fine, but let me worry about the rebase, if you don't mind. :) |
lexical-react
to TypeScript (6/n)lexical-react
to TypeScript (7/n)
290d297
to
72bec1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Continues work on #1242. This PR includes:
lexical-react
Migration steps
I ran the below script to update the directories automatically, and then fixed each compiler linter error manually:
Bundle sizes
Bundle sizes are consistent with
main
. Below are some sample packages:LexicalCharacterLimitPlugin.prod.js
LexicalAutoLinkPlugin.prod.js
LexicalTablePlugin.prod.js