Add CommentPlugin

[trueadm]

This adds the CommentsPlugin to the playground. There are few things to point out:

• It doesn't work with collaboration.
• MarkNodes can be buggy and need refining.
• You can't edit comments.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lexical	✅ Ready (Inspect)	Visit Preview	Apr 29, 2022 at 1:56PM (UTC)
lexical-playground	✅ Ready (Inspect)	Visit Preview	Apr 29, 2022 at 1:56PM (UTC)

[fantactuka]

Content marks is the trickiest part, but looks great anyways 👍

[zurfyx]

Looks amazing!

Feedback:

• I like the use of an ElementNode to mark these, especially since they have to be synced over collab.

• The use of reference vs comment is confusing. Why is it called CommetNode but you're instead creating a Reference with a quote in the plugin?

• Can I ever delete a reference? How would that work UX wise? I was expecting the reference to be deleted once there are no comments.

• We should prevent creating a new reference on the same exact reference. In fact, I find it a bit confusing that the reference quote never updates. I guess it's good for the historical context but the fact that I can create multiples with the same text and that the node on the editor can potentially point to a completely different text is confusing.

• How are we thinking about collab given that the information is currently decouple from the EditorState? Are we expecting the app to have their own mechanism for these or is this something we want to iterate on later?

• If I delete a comment and undo:

Uncaught Error: Cannot call set() on a frozen Lexical node map

[trueadm]

Addressed your feedback!

How are we thinking about collab given that the information is currently decouple from the EditorState? Are we expecting the app to have their own mechanism for these or is this something we want to iterate on later?

There will be a separate model for CommentPlugin's state that will be represented in another Yjs doc. I'll do that next week when I get some time, as it's quite a lot of work.