Command priorities as constants #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
trueadm,
thegreatercurve,
tylerjbainbridge and
acywatson
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fantactuka
approved these changes
Apr 16, 2022
trueadm
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlikely HTML conversion we have always labeled priorities in code: CRITICAL, HIGH etc.
Priorities are traditionally numbers and to do so requires to have a cast around listener like
(0: EditorPriority)or similar. This is not quite ergonomic and tends to lead to either:For this reason, I'm proposing to standarize this into the core.
A very similar strategy would be to ship an object with these values but 5 constants will be way lighter than shipping an object with values, which will pay off in larger apps.