Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table cell height #1756

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

always-maap
Copy link
Contributor

fixes: #1741

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2022
@vercel
Copy link

vercel bot commented Apr 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

lexical – ./packages/lexical-website-new

🔍 Inspect: https://vercel.com/fbopensource/lexical/38dbEgGswErGQbxwkt76f2NZBMdr
✅ Preview: https://lexical-git-fork-always-maap-table-cell-height-fbopensource.vercel.app

lexical-playground – ./packages/lexical-playground

🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/EehVcSoYCMAm29Lk9e1M5bUc7xYu
✅ Preview: https://lexical-playground-git-fork-always-maap-tab-031e04-fbopensource.vercel.app

@acywatson
Copy link
Contributor

@tylerjbainbridge can you take a look?

@tylerjbainbridge
Copy link
Contributor

@always-maap can you attach some images of what it looks like? This seems like a good solution for now, but in the future we'll want it to auto size because the font size is determined from the theme and not a static number.

@always-maap
Copy link
Contributor Author

always-maap commented Apr 15, 2022

@always-maap can you attach some images of what it looks like? This seems like a good solution for now, but in the future we'll want it to auto size because the font size is determined from the theme and not a static number.

sure. I will give it a try later

before:
2022-04-15-233958_1920x1080_scrot
after:
2022-04-15-234015_1920x1080_scrot

@tylerjbainbridge
Copy link
Contributor

Looks good to me!

@tylerjbainbridge tylerjbainbridge merged commit deba537 into facebook:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables Bug: Default cell height should match height of one line of text.
4 participants