Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CharacterStylePopup top position #1681

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix CharacterStylePopup top position #1681

merged 1 commit into from
Apr 13, 2022

Conversation

always-maap
Copy link
Contributor

fixes #1677

@facebook-github-bot
Copy link
Contributor

Hi @always-maap!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vercel
Copy link

vercel bot commented Apr 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

lexical-playground – ./packages/lexical-playground

🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/FwdpF4roczr8DpgNSTZM9weoRVn7
✅ Preview: https://lexical-playground-git-fork-always-maap-main-fbopensource.vercel.app

lexical – ./packages/lexical-website

🔍 Inspect: https://vercel.com/fbopensource/lexical/8mxzfYGKN8jhH1vbnuwdEVfurvyj
✅ Preview: https://lexical-git-fork-always-maap-main-fbopensource.vercel.app

lexical-website-new – ./packages/lexical-website-new

🔍 Inspect: https://vercel.com/fbopensource/lexical-website-new/3Kfhgdh4PrMAhotnx5VWvnSokjAk
✅ Preview: https://lexical-website-new-git-fork-always-maap-main-fbopensource.vercel.app

@trueadm
Copy link
Collaborator

trueadm commented Apr 13, 2022

@always-maap please can you sign the CLA? Otherwise this looks good!

@always-maap
Copy link
Contributor Author

always-maap commented Apr 13, 2022

@always-maap please can you sign the CLA? Otherwise this looks good!

I did as soon as got the fail check

2022-04-14-013254_1920x1080_scrot

@trueadm trueadm merged commit 9101689 into facebook:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: character-style-popup get incorrect position when multiple paragraphs are selected
3 participants