-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @lexical/overflow @lexical/link #1556
Conversation
This pull request is being automatically deployed with Vercel (learn more). lexical – ./packages/lexical-website🔍 Inspect: https://vercel.com/fbopensource/lexical/CbGnnmEcG4WTqQsSaBKHRrQ9sTPy lexical-playground – ./packages/lexical-playground🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/C8uamrLueTwQNXAPzCWKpVvTA1BD lexical-website-new – ./packages/lexical-website-new🔍 Inspect: https://vercel.com/fbopensource/lexical-website-new/H3RWvDSpXLKXe4JKRqMzVaHCLTC8 |
Although I like the idea of splitting code into packages, as a library user I'd be a bit annoyed to have to run For those lazy users, can we do some umbrella package like Maybe installing package is not a bit problem, but then discoverability of API's is quite hard since it's not available until you install all those packages. With bundle package it could be easier by just using IDE's auto suggestion |
@fantactuka Why would they need to do that? They just do |
At the same time this plays against our principle of 1 way of doing things, but I do agree with your sentiment. We'll have to make documentation clear. Probably worth a discussion about this offline too. |
Accepting as this PR is just following the trend we started weeks ago. We can follow up with a discussion offline |
I don't think is really a big issue. See Babel for an example of how many packages they have, which was hundreds last time I checked. You typically require a core package, which pulls in the others on demand. The issue with |
* Add @lexical/overflow @lexical/link * Fix tests
This PR removes all the extended nodes from core and instead moves out Links and Overflow nodes to their respective packages instead. I removed ExtendedNodes, as it was leaky and a bit of a temp hack (it should be done on app level, not framework).