Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @lexical/overflow @lexical/link #1556

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Add @lexical/overflow @lexical/link #1556

merged 2 commits into from
Mar 25, 2022

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Mar 25, 2022

This PR removes all the extended nodes from core and instead moves out Links and Overflow nodes to their respective packages instead. I removed ExtendedNodes, as it was leaky and a bit of a temp hack (it should be done on app level, not framework).

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

lexical – ./packages/lexical-website

🔍 Inspect: https://vercel.com/fbopensource/lexical/CbGnnmEcG4WTqQsSaBKHRrQ9sTPy
✅ Preview: https://lexical-git-lexical-link-overflow-fbopensource.vercel.app

lexical-playground – ./packages/lexical-playground

🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/C8uamrLueTwQNXAPzCWKpVvTA1BD
✅ Preview: https://lexical-playground-git-lexical-link-overflow-fbopensource.vercel.app

lexical-website-new – ./packages/lexical-website-new

🔍 Inspect: https://vercel.com/fbopensource/lexical-website-new/H3RWvDSpXLKXe4JKRqMzVaHCLTC8
✅ Preview: https://lexical-website-new-git-lexical-link-overflow-fbopensource.vercel.app

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2022
@fantactuka
Copy link
Contributor

Although I like the idea of splitting code into packages, as a library user I'd be a bit annoyed to have to run npm install lexical @lexical/code @lexical/plain .. 10 more ..

For those lazy users, can we do some umbrella package like @lexical/all that has all it as a dependency with re-exports @lexical/all/code.

Maybe installing package is not a bit problem, but then discoverability of API's is quite hard since it's not available until you install all those packages. With bundle package it could be easier by just using IDE's auto suggestion

@trueadm
Copy link
Collaborator Author

trueadm commented Mar 25, 2022

@fantactuka Why would they need to do that? They just do npm install @lexical/react and then use the plugins?

@zurfyx
Copy link
Member

zurfyx commented Mar 25, 2022

For those lazy users, can we do some umbrella package like @lexical/all that has all it as a dependency with re-exports @lexical/all/code.

At the same time this plays against our principle of 1 way of doing things, but I do agree with your sentiment. We'll have to make documentation clear.

Probably worth a discussion about this offline too.

@zurfyx
Copy link
Member

zurfyx commented Mar 25, 2022

Accepting as this PR is just following the trend we started weeks ago. We can follow up with a discussion offline

@trueadm trueadm merged commit 9552b06 into main Mar 25, 2022
@trueadm trueadm deleted the lexical-link-overflow branch March 25, 2022 15:56
@trueadm
Copy link
Collaborator Author

trueadm commented Mar 25, 2022

I don't think is really a big issue. See Babel for an example of how many packages they have, which was hundreds last time I checked. You typically require a core package, which pulls in the others on demand. The issue with @lexical/all is that it promotes a single mega package, which skews npm install times.

acywatson pushed a commit that referenced this pull request Apr 9, 2022
* Add @lexical/overflow @lexical/link

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants