Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rich/plain/dragon logic to separate packages #1555

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Mar 25, 2022

This PR moves rich text/plain text/dragon support logic into their own packages. Rich text includes HeadingNode and QuoteNode.

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

lexical – ./packages/lexical-website

🔍 Inspect: https://vercel.com/fbopensource/lexical/4Xp4kdj59T8AeFKwHGh5LaUTBhFh
✅ Preview: https://lexical-git-move-base-packages-fbopensource.vercel.app

lexical-playground – ./packages/lexical-playground

🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/6SffMSdwsfDPjxKgocXp5CgAiD2n
✅ Preview: https://lexical-playground-git-move-base-packages-fbopensource.vercel.app

lexical-website-new – ./packages/lexical-website-new

🔍 Inspect: https://vercel.com/fbopensource/lexical-website-new/BrNnPcURcKnGAW1MXcp384ntme48
✅ Preview: https://lexical-website-new-git-move-base-packages-fbopensource.vercel.app

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2022
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I guess we can add the flow and TS declarations separately

@trueadm trueadm merged commit 950c21f into main Mar 25, 2022
@trueadm trueadm deleted the move-base-packages branch March 25, 2022 13:01
acywatson pushed a commit that referenced this pull request Apr 9, 2022
* Move rich/plain/dragon logic to seperate pacakges

* Clean up entity logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants