Move command type out of listeners to registerCommandListener
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). lexical – ./packages/lexical-website🔍 Inspect: https://vercel.com/fbopensource/lexical/2SkLtyig8xrcnasmZ4znRrjA82uL lexical-playground – ./packages/lexical-playground🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/3mGotWvrgU7Q7p367sWbANdkyavM lexical-website-new – ./packages/lexical-website-new🔍 Inspect: https://vercel.com/fbopensource/lexical-website-new/EGHR2sU2KtpGCG9hrQzQX6zn1CJi |
facebook-github-bot
added
the
CLA Signed
thegreatercurve
force-pushed
the
flow-type-move-into-args
branch
from
fe53120 to
5b32429
Compare
thegreatercurve
force-pushed
the
flow-type-move-into-args
branch
from
1c3d926 to
9e58c29
Compare
thegreatercurve
requested review from
trueadm,
zurfyx,
tylerjbainbridge,
fantactuka and
acywatson
thegreatercurve
force-pushed
the
flow-type-move-into-args
branch
from
95f0b0c to
bfa9a0b
Compare
thegreatercurve
force-pushed
the
flow-type-move-into-args
branch
from
35ae42c to
4aec50a
Compare
btezzxxt
added a commit
that referenced
this pull request
Apr 1, 2022
btezzxxt
added a commit
that referenced
this pull request
Apr 1, 2022
acywatson
pushed a commit
that referenced
this pull request
Apr 9, 2022
* Move command type out of listener callback to registerCommandListener outer method * Remove optional chaining * correct boolean values returned from some command callbacks * Fix bug with priorty ordering * clarify type * Fix failing E2E * Fix E2E bug * Wrap mutiple commands in withSubscriptions * update docs * Address small issues and add unit test * remove console logs * Fix E2E bugs * Fix E2E bugs * Remove flow fixmes and add invariant
acywatson
pushed a commit
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1412 and #1512, we're trying to store commands by their type, and then by their priority order. This should allow us call listeners less often, and removes the need for users to have to check types in callbacks. Plus it should allow us to more easily type the commands themselves.
This effectively changes how we store the command from the below:
In terms of performance, I don't think we're taking much of a hit, especially since #1509.
I 6x throttled the CPU of Chrome, and compared the task times for typing characters compared to
main, and they average around the same number of milliseconds.I was also able to add
console.startEndandconsole.startEndto the beginning and end ofexecCommandand the times for the function to run appear fairly consistent across this and main.main
branch