Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table Flow Types #1425

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Add Table Flow Types #1425

merged 2 commits into from
Mar 8, 2022

Conversation

tylerjbainbridge
Copy link
Contributor

Closes #1422

@tylerjbainbridge tylerjbainbridge requested a review from zurfyx March 4, 2022 15:52
@vercel
Copy link

vercel bot commented Mar 4, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

lexical – ./packages/lexical-website

🔍 Inspect: https://vercel.com/fbopensource/lexical/57hEWoCuxEn64GMLHKt1wQBvrqL7
✅ Preview: https://lexical-git-add-table-flow-types-fbopensource.vercel.app

lexical-playground – ./packages/lexical-playground

🔍 Inspect: https://vercel.com/fbopensource/lexical-playground/J3Jy1RwE6zZCm1ZKh8qnM4hAzbSC
✅ Preview: https://lexical-playground-git-add-table-flow-types-fbopensource.vercel.app

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2022
zurfyx
zurfyx approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, just one last thing, can we copy-paste the .flow.js into a .d.ts. We offer both Flow and TypeScript types now!

@tylerjbainbridge tylerjbainbridge merged commit 9b65c74 into main Mar 8, 2022
@tylerjbainbridge tylerjbainbridge deleted the add-table-flow-types branch March 8, 2022 20:12
acywatson pushed a commit that referenced this pull request Apr 9, 2022
@tylerjbainbridge @acywatson
Add Table Flow Types (#1425)
1b843a2 
* Add Table Flow Types

* Fix flow & TS types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table flow/TS types
3 participants
@tylerjbainbridge @zurfyx @facebook-github-bot